Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb70a1ae authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

tcp: cleanup sk_tx_skb_cache before reuse 



TCP stack relies on the fact that a freshly allocated skb
has skb->cb[] and skb_shinfo(skb)->tx_flags cleared.

When recycling tx skb, we must ensure these fields are cleared.

Fixes: 472c2e07 ("tcp: add one skb cache for tx")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: default avatarSoheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent faddd6cf

net/ipv4/tcp.c

+2 −0
Original line number Diff line number Diff line
@@ -872,6 +872,8 @@ struct sk_buff *sk_stream_alloc_skb(struct sock *sk, int size, gfp_t gfp, 
			sk->sk_tx_skb_cache = NULL;

			pskb_trim(skb, 0);

			INIT_LIST_HEAD(&skb->tcp_tsorted_anchor);

			skb_shinfo(skb)->tx_flags = 0;

			memset(TCP_SKB_CB(skb), 0, sizeof(struct tcp_skb_cb));

			return skb;

		}

	}