Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb32cfcd authored by Kangjie Lu's avatar Kangjie Lu Committed by David S. Miller
Browse files

net: qlogic: fix a potential NULL pointer dereference 



In case create_singlethread_workqueue fails, the fix returns
-ENOMEM to avoid NULL pointer dereference.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 10010493

drivers/net/ethernet/qlogic/qla3xxx.c

+6 −0
Original line number Diff line number Diff line
@@ -3886,6 +3886,12 @@ static int ql3xxx_probe(struct pci_dev *pdev, 
	netif_stop_queue(ndev);



	qdev->workqueue = create_singlethread_workqueue(ndev->name);

	if (!qdev->workqueue) {

		unregister_netdev(ndev);

		err = -ENOMEM;

		goto err_out_iounmap;

	}



	INIT_DELAYED_WORK(&qdev->reset_work, ql_reset_work);

	INIT_DELAYED_WORK(&qdev->tx_timeout_work, ql_tx_timeout_work);

	INIT_DELAYED_WORK(&qdev->link_state_work, ql_link_state_machine_work);