Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb2b1216 authored Jun 08, 2021 by Zheng Yongjun Committed by Sasha Levin Jun 30, 2021

net: ipv4: Remove unneed BUG() function



[ Upstream commit 5ac6b198d7e312bd10ebe7d58c64690dc59cc49a ]

When 'nla_parse_nested_deprecated' failed, it's no need to
BUG() here, return -EINVAL is ok.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e0c950d2

net/ipv4/devinet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1989,7 +1989,7 @@ static int inet_set_link_af(struct net_device dev, const struct nlattr nla)
		return -EAFNOSUPPORT;

		if (nla_parse_nested_deprecated(tb, IFLA_INET_MAX, nla, NULL, NULL) < 0)
		BUG();
		return -EINVAL;

		if (tb[IFLA_INET_CONF]) {
		nla_for_each_nested(a, tb[IFLA_INET_CONF], rem)

net/ipv6/addrconf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5761,7 +5761,7 @@ static int inet6_set_link_af(struct net_device dev, const struct nlattr nla)
		return -EAFNOSUPPORT;

		if (nla_parse_nested_deprecated(tb, IFLA_INET6_MAX, nla, NULL, NULL) < 0)
		BUG();
		return -EINVAL;

		if (tb[IFLA_INET6_TOKEN]) {
		err = inet6_set_iftoken(idev, nla_data(tb[IFLA_INET6_TOKEN]));