Commit eb0b419e authored Jan 10, 2018 by Jin Yao Committed by Arnaldo Carvalho de Melo Jan 17, 2018

perf report: Improve error msg when no first/last sample time found



The following message will be returned to user when executing
'perf report --time' if perf data file doesn't contain the
first/last sample time.

"HINT: no first/last sample time found in perf data.
 Please use latest perf binary to execute 'perf record'
 (if '--buildid-all' is enabled, needs to set '--timestamp-boundary')."

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1515596433-24653-2-git-send-email-yao.jin@linux.intel.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 0d3dcc0e

tools/perf/builtin-report.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1300,7 +1300,9 @@ int cmd_report(int argc, const char **argv)
		if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) {
		if (session->evlist->first_sample_time == 0 &&
		session->evlist->last_sample_time == 0) {
		pr_err("No first/last sample time in perf data\n");
		pr_err("HINT: no first/last sample time found in perf data.\n"
		"Please use latest perf binary to execute 'perf record'\n"
		"(if '--buildid-all' is enabled, please set '--timestamp-boundary').\n");
		return -EINVAL;
		}