Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eafb2936 authored by Alexandre Chartre's avatar Alexandre Chartre Committed by Greg Kroah-Hartman
Browse files

objtool: is_fentry_call() crashes if call has no destination 



commit 87cf61fe848ca8ddf091548671e168f52e8a718e upstream.

Fix is_fentry_call() so that it works if a call has no destination
set (call_dest). This needs to be done in order to support intra-
function calls.

Signed-off-by: default avatarAlexandre Chartre <alexandre.chartre@oracle.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com


Signed-off-by: default avatarRui Qi <qirui.001@bytedance.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 396dbbc1

tools/objtool/check.c

+1 −1
Original line number Diff line number Diff line
@@ -1367,7 +1367,7 @@ static int decode_sections(struct objtool_file *file) 


static bool is_fentry_call(struct instruction *insn)

{

	if (insn->type == INSN_CALL &&

	if (insn->type == INSN_CALL && insn->call_dest &&

	    insn->call_dest->type == STT_NOTYPE &&

	    !strcmp(insn->call_dest->name, "__fentry__"))

		return true;