Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ead0689b authored by Bitterblue Smith's avatar Bitterblue Smith Committed by Greg Kroah-Hartman
Browse files

wifi: rtl8xxxu: gen2: Turn on the rate control 



[ Upstream commit 791082ec0ab843e0be07c8ce3678e4c2afd2e33d ]

Re-enable the function rtl8xxxu_gen2_report_connect.

It informs the firmware when connecting to a network. This makes the
firmware enable the rate control, which makes the upload faster.

It also informs the firmware when disconnecting from a network. In the
past this made reconnecting impossible because it was sending the
auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
(TXDESC_QUEUE_MGNT):

wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out

Probably the firmware disables the unnecessary TX queues when it
knows it's disconnected.

However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
skb misuse in TX queue selection").

Fixes: c59f13bb ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconnecting")
Signed-off-by: default avatarBitterblue Smith <rtl8821cerfe2@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/43200afc-0c65-ee72-48f8-231edd1df493@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0a77a966

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

+2 −6
Original line number Diff line number Diff line
@@ -4372,12 +4372,9 @@ void rtl8xxxu_gen1_report_connect(struct rtl8xxxu_priv *priv, 
void rtl8xxxu_gen2_report_connect(struct rtl8xxxu_priv *priv,

				  u8 macid, bool connect)

{

#ifdef RTL8XXXU_GEN2_REPORT_CONNECT

	/*

	 * Barry Day reports this causes issues with 8192eu and 8723bu

	 * devices reconnecting. The reason for this is unclear, but

	 * until it is better understood, leave the code in place but

	 * disabled, so it is not lost.

	 * The firmware turns on the rate control when it knows it's

	 * connected to a network.

	 */

	struct h2c_cmd h2c;
@@ -4390,7 +4387,6 @@ void rtl8xxxu_gen2_report_connect(struct rtl8xxxu_priv *priv, 
		h2c.media_status_rpt.parm &= ~BIT(0);



	rtl8xxxu_gen2_h2c_cmd(priv, &h2c, sizeof(h2c.media_status_rpt));

#endif

}



void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)