Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea89604f authored by Jitendra Bhivare's avatar Jitendra Bhivare Committed by Martin K. Petersen
Browse files

scsi: be2iscsi: Fix to use correct configuration values 



Following configuration is created with what driver exports:
iface.vlan_id = 65535
iface.vlan_priority = 255
iface.vlan_state = <empty>

vlan_state is empty as iscsiadm doesn't process "Disabled".
When applying this configuration, iscsiadm checks for if vlan_state is
"disable" if not it enables with value in vlan_id. 65535 not being valid
value, 0 is applied.

Use "enable" or "disable" for ISCSI_NET_PARAM.

Signed-off-by: default avatarJitendra Bhivare <jitendra.bhivare@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0b924e55

drivers/scsi/be2iscsi/be_iscsi.c

+3 −3
Original line number Diff line number Diff line
@@ -567,8 +567,8 @@ static int be2iscsi_get_if_param(struct beiscsi_hba *phba, 
		break;

	case ISCSI_NET_PARAM_VLAN_ENABLED:

		len = sprintf(buf, "%s\n",

			     (if_info->vlan_priority == BEISCSI_VLAN_DISABLE)

			     ? "Disabled\n" : "Enabled\n");

			      (if_info->vlan_priority == BEISCSI_VLAN_DISABLE) ?

			      "disable" : "enable");

		break;

	case ISCSI_NET_PARAM_VLAN_ID:

		if (if_info->vlan_priority == BEISCSI_VLAN_DISABLE)
@@ -620,7 +620,7 @@ int be2iscsi_iface_get_param(struct iscsi_iface *iface, 
		len = be2iscsi_get_if_param(phba, iface, param, buf);

		break;

	case ISCSI_NET_PARAM_IFACE_ENABLE:

		len = sprintf(buf, "enabled\n");

		len = sprintf(buf, "enable\n");

		break;

	case ISCSI_NET_PARAM_IPV4_GW:

		memset(&gateway, 0, sizeof(gateway));