Unverified Commit ea7b971c authored Feb 15, 2019 by Colin Ian King Committed by Mark Brown Feb 19, 2019

regulator: axp20x: remove a redundant null check on rdev

Currently rdev is dereferenced when assigning desc before rdev is null
checked, this is leading to static analysis warnings. However, rdev
can never be null, so the null check is redundant and can be removed.

Detected by CoverityScan, CID#1476031 ("Dereference before null check")

Fixes: 77e3e3b1 ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent afb29714

drivers/regulator/axp20x-regulator.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
		const int *slew_rates;
		int rate_count = 0;

		if (!rdev)
		return -EINVAL;

		desc = rdev->desc;

		switch (axp20x->variant) {