Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea64c727 authored by Nilesh Javali's avatar Nilesh Javali Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Array index may go out of bound 



[ Upstream commit d721b591b95cf3f290f8a7cbe90aa2ee0368388d ]

Klocwork reports array 'vha->host_str' of size 16 may use index value(s)
16..19.  Use snprintf() instead of sprintf().

Cc: stable@vger.kernel.org
Co-developed-by: default avatarBikash Hazarika <bhazarika@marvell.com>
Signed-off-by: default avatarBikash Hazarika <bhazarika@marvell.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-2-njavali@marvell.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5e387df4

drivers/scsi/qla2xxx/qla_os.c

+2 −1
Original line number Diff line number Diff line
@@ -4831,7 +4831,8 @@ struct scsi_qla_host *qla2x00_create_host(struct scsi_host_template *sht, 
	}

	INIT_DELAYED_WORK(&vha->scan.scan_work, qla_scan_work_fn);



	sprintf(vha->host_str, "%s_%lu", QLA2XXX_DRIVER_NAME, vha->host_no);

	snprintf(vha->host_str, sizeof(vha->host_str), "%s_%lu",

		 QLA2XXX_DRIVER_NAME, vha->host_no);

	ql_dbg(ql_dbg_init, vha, 0x0041,

	    "Allocated the host=%p hw=%p vha=%p dev_name=%s",

	    vha->host, vha->hw, vha,