Commit ea1b4c31 authored Jul 27, 2023 by Colin Ian King Committed by Greg Kroah-Hartman Aug 16, 2023

radix tree test suite: fix incorrect allocation size for pthreads

commit cac7ea57a06016e4914848b707477fb07ee4ae1c upstream.

Currently the pthread allocation for each array item is based on the size
of a pthread_t pointer and should be the size of the pthread_t structure,
so the allocation is under-allocating the correct size.  Fix this by using
the size of each element in the pthreads array.

Static analysis cppcheck reported:
tools/testing/radix-tree/regression1.c:180:2: warning: Size of pointer
'threads' used instead of size of its data. [pointerSize]

Link: https://lkml.kernel.org/r/20230727160930.632674-1-colin.i.king@gmail.com


Fixes: 1366c37e ("radix tree test harness")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent aa0bfe16

tools/testing/radix-tree/regression1.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -177,7 +177,7 @@ void regression1_test(void)
		nr_threads = 2;
		pthread_barrier_init(&worker_barrier, NULL, nr_threads);

		threads = malloc(nr_threads * sizeof(pthread_t *));
		threads = malloc(nr_threads * sizeof(*threads));

		for (i = 0; i < nr_threads; i++) {
		arg = i;