Commit e962610f authored Sep 13, 2012 by Ming Lei Committed by John W. Linville Sep 24, 2012

wireless: ath9k-htc: fix possible use after free



Inside ath9k_hif_usb_firmware_fail(), the instance of
'struct struct hif_device_usb' may be freed by
ath9k_hif_usb_disconnect() after

	complete(&hif_dev->fw_done);

But 'hif_dev' is still accessed after the line code
above is executed.

This patch fixes the issue by not accessing 'hif_dev'
after 'complete(&hif_dev->fw_done)' inside
ath9k_hif_usb_firmware_fail().

Cc: ath9k-devel@lists.ath9k.org
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 7a034146

drivers/net/wireless/ath/ath9k/hif_usb.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1072,14 +1072,15 @@ static void ath9k_hif_usb_dev_deinit(struct hif_device_usb *hif_dev)
		*/
		static void ath9k_hif_usb_firmware_fail(struct hif_device_usb *hif_dev)
		{
		struct device *parent = hif_dev->udev->dev.parent;
		struct device *dev = &hif_dev->udev->dev;
		struct device *parent = dev->parent;

		complete(&hif_dev->fw_done);

		if (parent)
		device_lock(parent);

		device_release_driver(&hif_dev->udev->dev);
		device_release_driver(dev);

		if (parent)
		device_unlock(parent);