Commit e92ce12e authored Oct 31, 2014 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Nov 05, 2014

perf tools: Add gzip decompression support for kernel module



Now my Archlinux box shows module symbols correctly.

Before:
  $ perf report --stdio
  Failed to open /tmp/perf-3477.map, continuing without symbols
  no symbols found in /usr/bin/date, maybe install a debug package?
  No kallsyms or vmlinux with build-id 7b4ea0a49ae2111925857099aaf05c3246ff33e0 was found
  [drm] with build id 7b4ea0a49ae2111925857099aaf05c3246ff33e0 not found, continuing without symbols
  No kallsyms or vmlinux with build-id edd931629094b660ca9dec09a1b635c8d87aa2ee was found
  [jbd2] with build id edd931629094b660ca9dec09a1b635c8d87aa2ee not found, continuing without symbols
  No kallsyms or vmlinux with build-id a7b1eada671c34933e5610bb920b2ca4945a82c3 was found
  [ext4] with build id a7b1eada671c34933e5610bb920b2ca4945a82c3 not found, continuing without symbols
  No kallsyms or vmlinux with build-id d69511fa3e5840e770336ef45b06c83fef8d74e3 was found
  [scsi_mod] with build id d69511fa3e5840e770336ef45b06c83fef8d74e3 not found, continuing without symbols
  No kallsyms or vmlinux with build-id af0430af13461af058770ee9b87afc07922c2e77 was found
  [libata] with build id af0430af13461af058770ee9b87afc07922c2e77 not found, continuing without symbols
  No kallsyms or vmlinux with build-id aaeedff8160ce631a5f0333591c6ff291201d29f was found
  [libahci] with build id aaeedff8160ce631a5f0333591c6ff291201d29f not found, continuing without symbols
  No kallsyms or vmlinux with build-id c57907712becaf662dc4981824bb372c0441d605 was found
  [mac80211] with build id c57907712becaf662dc4981824bb372c0441d605 not found, continuing without symbols
  No kallsyms or vmlinux with build-id e0589077cc0ec8c3e4c40eb9f2d9e69d236bee8f was found
  [iwldvm] with build id e0589077cc0ec8c3e4c40eb9f2d9e69d236bee8f not found, continuing without symbols
  No kallsyms or vmlinux with build-id 2d86086bf136bf374a2f029cf85a48194f9b950b was found
  [cfg80211] with build id 2d86086bf136bf374a2f029cf85a48194f9b950b not found, continuing without symbols
  No kallsyms or vmlinux with build-id 4493c48599bdb3d91d0f8db5150e0be33fdd9221 was found
  [iwlwifi] with build id 4493c48599bdb3d91d0f8db5150e0be33fdd9221 not found, continuing without symbols
  ...
  #
  # Overhead  Command          Shared Object            Symbol
  # ........  ...............  .......................  ........................................................
  #
       0.03%  swapper          [ext4]                   [k] 0x000000000000fe2e
       0.03%  swapper          [kernel.kallsyms]        [k] account_entity_enqueue
       0.03%  swapper          [ext4]                   [k] 0x000000000000fc2b
       0.03%  irq/50-iwlwifi   [iwlwifi]                [k] 0x000000000000200b
       0.03%  swapper          [kernel.kallsyms]        [k] ktime_add_safe
       0.03%  swapper          [kernel.kallsyms]        [k] elv_completed_request
       0.03%  swapper          [libata]                 [k] 0x0000000000003997
       0.03%  swapper          [libahci]                [k] 0x0000000000001f25
       0.03%  swapper          [kernel.kallsyms]        [k] rb_next
       0.03%  swapper          [kernel.kallsyms]        [k] blk_finish_request
       0.03%  swapper          [ext4]                   [k] 0x0000000000010248
       0.00%  perf             [kernel.kallsyms]        [k] native_write_msr_safe

After:
  $ perf report --stdio
  Failed to open /tmp/perf-3477.map, continuing without symbols
  no symbols found in /usr/bin/tr, maybe install a debug package?
  ...
  #
  # Overhead  Command          Shared Object                Symbol
  # ........  ...............  ...........................  ......................................................
  #

       0.04%  kworker/u16:3    [ext4]                       [k] ext4_read_block_bitmap
       0.03%  kworker/u16:0    [mac80211]                   [k] ieee80211_sta_reset_beacon_monitor
       0.02%  irq/50-iwlwifi   [mac80211]                   [k] ieee80211_get_bssid
       0.02%  firefox          [e1000e]                     [k] __ew32_prepare
       0.02%  swapper          [libahci]                    [k] ahci_handle_port_interrupt
       0.02%  emacs            libglib-2.0.so.0.4000.0      [.] g_mutex_unlock
       0.02%  swapper          [e1000e]                     [k] e1000_clean_tx_irq
       0.02%  dwm              [kernel.kallsyms]            [k] __schedule
       0.02%  gnome-terminal-  [vdso]                       [.] __vdso_clock_gettime
       0.02%  swapper          [e1000e]                     [k] e1000_alloc_rx_buffers
       0.02%  irq/50-iwlwifi   [mac80211]                   [k] ieee80211_rx
       0.01%  firefox          [vdso]                       [.] __vdso_gettimeofday
       0.01%  irq/50-iwlwifi   [iwlwifi]                    [k] iwl_pcie_rxq_restock.part.13

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/87h9yexshi.fsf@sejong.aot.lge.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent c00c48fc

tools/perf/Makefile.perf

+7 −0

Original line number	Diff line number	Diff line
		@@ -66,6 +66,9 @@ include config/utilities.mak
		#
		# Define NO_PERF_READ_VDSOX32 if you do not want to build perf-read-vdsox32
		# for reading the x32 mode 32-bit compatibility VDSO in 64-bit mode
		#
		# Define NO_ZLIB if you do not want to support compressed kernel modules


		ifeq ($(srctree),)
		srctree := $(patsubst %/,%,$(dir $(shell pwd)))
		@@ -584,6 +587,10 @@ ifndef NO_LIBNUMA
		BUILTIN_OBJS += $(OUTPUT)bench/numa.o
		endif

		ifndef NO_ZLIB
		LIB_OBJS += $(OUTPUT)util/zlib.o
		endif

		ifdef ASCIIDOC8
		export ASCIIDOC8
		endif

tools/perf/config/Makefile

+13 −2

Original line number	Diff line number	Diff line
		@@ -200,7 +200,8 @@ CORE_FEATURE_TESTS = \
		libunwind \
		stackprotector-all \
		timerfd \
		libdw-dwarf-unwind
		libdw-dwarf-unwind \
		zlib

		LIB_FEATURE_TESTS = \
		dwarf \
		@@ -214,7 +215,8 @@ LIB_FEATURE_TESTS = \
		libpython \
		libslang \
		libunwind \
		libdw-dwarf-unwind
		libdw-dwarf-unwind \
		zlib

		VF_FEATURE_TESTS = \
		backtrace \
		@@ -604,6 +606,15 @@ ifneq ($(filter -lbfd,$(EXTLIBS)),)
		CFLAGS += -DHAVE_LIBBFD_SUPPORT
		endif

		ifndef NO_ZLIB
		ifeq ($(feature-zlib), 1)
		CFLAGS += -DHAVE_ZLIB_SUPPORT
		EXTLIBS += -lz
		else
		NO_ZLIB := 1
		endif
		endif

		ifndef NO_BACKTRACE
		ifeq ($(feature-backtrace), 1)
		CFLAGS += -DHAVE_BACKTRACE_SUPPORT

tools/perf/config/feature-checks/Makefile

+6 −2

Original line number	Diff line number	Diff line
		@@ -29,7 +29,8 @@ FILES= \
		test-timerfd.bin \
		test-libdw-dwarf-unwind.bin \
		test-compile-32.bin \
		test-compile-x32.bin
		test-compile-x32.bin \
		test-zlib.bin

		CC := $(CROSS_COMPILE)gcc -MD
		PKG_CONFIG := $(CROSS_COMPILE)pkg-config
		@@ -41,7 +42,7 @@ BUILD = $(CC) $(CFLAGS) -o $(OUTPUT)$@ $(patsubst %.bin,%.c,$@) $(LDFLAGS)
		###############################

		test-all.bin:
		$(BUILD) -Werror -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl
		$(BUILD) -Werror -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz

		test-hello.bin:
		$(BUILD)
		@@ -139,6 +140,9 @@ test-compile-32.bin:
		test-compile-x32.bin:
		$(CC) -mx32 -o $(OUTPUT)$@ test-compile.c

		test-zlib.bin:
		$(BUILD) -lz

		-include *.d

		###############################

tools/perf/config/feature-checks/test-all.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -93,6 +93,10 @@
		# include "test-sync-compare-and-swap.c"
		#undef main

		#define main main_test_zlib
		# include "test-zlib.c"
		#undef main

		int main(int argc, char *argv[])
		{
		main_test_libpython();
		@@ -116,6 +120,7 @@ int main(int argc, char *argv[])
		main_test_stackprotector_all();
		main_test_libdw_dwarf_unwind();
		main_test_sync_compare_and_swap(argc, argv);
		main_test_zlib();

		return 0;
		}

tools/perf/config/feature-checks/test-zlib.c

0 → 100644

+9 −0

Original line number	Diff line number	Diff line
		#include <zlib.h>

		int main(void)
		{
		z_stream zs;

		inflateInit(&zs);
		return 0;
		}