Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e916b80d authored by Joe Perches's avatar Joe Perches Committed by Jonathan Cameron
Browse files

inkern: iio_device_put after incorrect return/goto 



The code uses

    return foo;
    goto err_type;

when instead the form should have been

    ret = foo;
    goto err_type;

Here this causes a useful iio_device_put to be skipped.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 702df9f1

drivers/iio/inkern.c

+1 −1
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ static int __of_iio_channel_get(struct iio_channel *channel, 
	channel->indio_dev = indio_dev;

	index = iiospec.args_count ? iiospec.args[0] : 0;

	if (index >= indio_dev->num_channels) {

		return -EINVAL;

		err = -EINVAL;

		goto err_put;

	}

	channel->channel = &indio_dev->channels[index];