Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8e963cf authored by Mayank Rana's avatar Mayank Rana
Browse files

dwc3: gadget: Don't block doorbell before halting USB controller 



HPG suggests to block ringing of doorbell towards IPA GSI channel
after sending end transfer command and halting USB controller.
Blocking ringing of doorbell before halting USB controller may
result into USB wrapper accessing IPA GSI doorbell register on
setting run/stop next composition switch.

Change-Id: Ie644f8a5afb06bc57cde596d527ffdaa5cf14d35
Signed-off-by: default avatarMayank Rana <mrana@codeaurora.org>
parent bf4eaa44

drivers/usb/dwc3/gadget.c

+8 −5
Original line number Diff line number Diff line
@@ -1962,7 +1962,7 @@ static int dwc3_gadget_set_selfpowered(struct usb_gadget *g, 
	return 0;

}



static void dwc3_stop_active_transfers(struct dwc3 *dwc)

static void dwc3_stop_active_transfers(struct dwc3 *dwc, bool block_db)

{

	u32 epnum;
@@ -1976,9 +1976,11 @@ static void dwc3_stop_active_transfers(struct dwc3 *dwc) 
		if (!(dep->flags & DWC3_EP_ENABLED))

			continue;



		if (dep->gsi && dep->direction)

		if (dep->gsi && dep->direction && block_db) {

			dbg_log_string("block_db with dep:%s", dep->name);

			dwc3_notify_event(dwc,

				DWC3_CONTROLLER_NOTIFY_CLEAR_DB, 0);

		}



		dwc3_remove_requests(dwc, dep);

	}
@@ -2064,9 +2066,10 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend) 
		 * According to dwc3 databook, it is must to remove any active

		 * transfers before trying to stop USB device controller. Hence

		 * call dwc3_stop_active_transfers() API before stopping USB

		 * device controller.

		 * device controller. Also don't block ringing of doorbell until

		 * controller is halted (i.e. second param as false).

		 */

		dwc3_stop_active_transfers(dwc);

		dwc3_stop_active_transfers(dwc, false);



		reg &= ~DWC3_DCTL_RUN_STOP;
@@ -3258,7 +3261,7 @@ static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc) 
		dwc3_ep0_stall_and_restart(dwc);

	}



	dwc3_stop_active_transfers(dwc);

	dwc3_stop_active_transfers(dwc, true);

	dwc3_clear_stall_all_ep(dwc);



	/* Reset device address to zero */