Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8e2da03 authored by Junlin Yang's avatar Junlin Yang Committed by Greg Kroah-Hartman
Browse files

pata_ipx4xx_cf: Fix unsigned comparison with less than zero 



[ Upstream commit c38ae56ee034623c59e39c0130ca0dec086c1a39 ]

The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irq', so making 'irq' an int, and change the position to
keep the code format.

./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
WARNING: Unsigned expression compared with zero: irq > 0

Signed-off-by: default avatarJunlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210409135426.1773-1-angkery@163.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5994e7a8

drivers/ata/pata_ixp4xx_cf.c

+1 −1
Original line number Diff line number Diff line
@@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap, 


static int ixp4xx_pata_probe(struct platform_device *pdev)

{

	unsigned int irq;

	struct resource *cs0, *cs1;

	struct ata_host *host;

	struct ata_port *ap;

	struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev);

	int ret;

	int irq;



	cs0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	cs1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);