Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8bfe3e7 authored by Satish Kharat's avatar Satish Kharat Committed by Martin K. Petersen
Browse files

scsi: fnic: Warn when calling done for IO not issued to fw 



The change is to print warning when scsi done is called for an IO that has
not yet been issued to the fw. Also adding sc and tag to debug print when
IO is cleaned up.

Signed-off-by: default avatarSatish Kharat <satishkh@cisco.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3567dca1

drivers/scsi/fnic/fnic_scsi.c

+8 −2
Original line number Diff line number Diff line
@@ -1415,8 +1415,9 @@ static void fnic_cleanup_io(struct fnic *fnic, int exclude_id) 
cleanup_scsi_cmd:

		sc->result = DID_TRANSPORT_DISRUPTED << 16;

		FNIC_SCSI_DBG(KERN_DEBUG, fnic->lport->host,

			      "%s: sc duration = %lu DID_TRANSPORT_DISRUPTED\n",

			      __func__, (jiffies - start_time));

			      "%s: tag:0x%x : sc:0x%p duration = %lu DID_TRANSPORT_DISRUPTED\n",

			      __func__, sc->request->tag, sc,

			      (jiffies - start_time));



		if (atomic64_read(&fnic->io_cmpl_skip))

			atomic64_dec(&fnic->io_cmpl_skip);
@@ -1425,6 +1426,11 @@ static void fnic_cleanup_io(struct fnic *fnic, int exclude_id) 


		/* Complete the command to SCSI */

		if (sc->scsi_done) {

			if (!(CMD_FLAGS(sc) & FNIC_IO_ISSUED))

				shost_printk(KERN_ERR, fnic->lport->host,

				"Calling done for IO not issued to fw: tag:0x%x sc:0x%p\n",

				 sc->request->tag, sc);



			FNIC_TRACE(fnic_cleanup_io,

				  sc->device->host->host_no, i, sc,

				  jiffies_to_msecs(jiffies - start_time),