Commit e8024cb4 authored Aug 27, 2019 by John Hurley Committed by David S. Miller Aug 28, 2019

nfp: flower: handle neighbour events on internal ports



Recent code changes to NFP allowed the offload of neighbour entries to FW
when the next hop device was an internal port. This allows for offload of
tunnel encap when the end-point IP address is applied to such a port.

Unfortunately, the neighbour event handler still rejects events that are
not associated with a repr dev and so the firmware neighbour table may get
out of sync for internal ports.

Fix this by allowing internal port neighbour events to be correctly
processed.

Fixes: 45756dfe ("nfp: flower: allow tunnels to output to internal port")
Signed-off-by: John Hurley <john.hurley@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 739d7c57

drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -328,13 +328,13 @@ nfp_tun_neigh_event_handler(struct notifier_block *nb, unsigned long event,

		flow.daddr = (__be32 )n->primary_key;

		/* Only concerned with route changes for representors. */
		if (!nfp_netdev_is_nfp_repr(n->dev))
		return NOTIFY_DONE;

		app_priv = container_of(nb, struct nfp_flower_priv, tun.neigh_nb);
		app = app_priv->app;

		if (!nfp_netdev_is_nfp_repr(n->dev) &&
		!nfp_flower_internal_port_can_offload(app, n->dev))
		return NOTIFY_DONE;

		/* Only concerned with changes to routes already added to NFP. */
		if (!nfp_tun_has_route(app, flow.daddr))
		return NOTIFY_DONE;