Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit e751287a authored by Gao Xiang's avatar Gao Xiang Committed by Michael Bestas
Browse files

erofs: fold in used-once helper erofs_workgroup_unfreeze_final() 

It's expected that erofs_workgroup_unfreeze_final() won't
be used in other places. Let's fold it to simplify the code.

Link: https://lore.kernel.org/r/20200729180235.25443-1-hsiangkao@redhat.com


Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Change-Id: Iff1ac2565ea40e67a6811ad7541d30e2c987897e
Signed-off-by: default avatarGao Xiang <hsiangkao@redhat.com>
parent 7a343c42

fs/erofs/utils.c

+3 −11
Original line number Diff line number Diff line
@@ -127,12 +127,6 @@ int erofs_workgroup_put(struct erofs_workgroup *grp) 
	return count;

}



static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)

{

	erofs_workgroup_unfreeze(grp, 0);

	__erofs_workgroup_free(grp);

}



static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,

					   struct erofs_workgroup *grp)

{
@@ -162,11 +156,9 @@ static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi, 
	 */

	DBG_BUGON(xa_erase(&sbi->managed_pslots, grp->index) != grp);



	/*

	 * If managed cache is on, last refcount should indicate

	 * the related workstation.

	 */

	erofs_workgroup_unfreeze_final(grp);

	/* last refcount should be connected with its managed pslot.  */

	erofs_workgroup_unfreeze(grp, 0);

	__erofs_workgroup_free(grp);

	return true;

}