Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e71a46cc authored by Liu Jian's avatar Liu Jian Committed by Greg Kroah-Hartman
Browse files

net: hisilicon: Fix potential use-after-free in hisi_femac_rx() 



[ Upstream commit 4640177049549de1a43e9bc49265f0cdfce08cfd ]

The skb is delivered to napi_gro_receive() which may free it, after
calling this, dereferencing skb may trigger use-after-free.

Fixes: 542ae60a ("net: hisilicon: Add Fast Ethernet MAC driver")
Signed-off-by: default avatarLiu Jian <liujian56@huawei.com>
Link: https://lore.kernel.org/r/20221203094240.1240211-1-liujian56@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7081cf86

drivers/net/ethernet/hisilicon/hisi_femac.c

+1 −1
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static int hisi_femac_rx(struct net_device *dev, int limit) 
		skb->protocol = eth_type_trans(skb, dev);

		napi_gro_receive(&priv->napi, skb);

		dev->stats.rx_packets++;

		dev->stats.rx_bytes += skb->len;

		dev->stats.rx_bytes += len;

next:

		pos = (pos + 1) % rxq->num;

		if (rx_pkts_num >= limit)