Commit e70d8b28 authored Jul 28, 2019 by Jean Delvare Committed by Greg Kroah-Hartman Jul 30, 2019

nvmem: Use the same permissions for eeprom as for nvmem



The compatibility "eeprom" attribute is currently root-only no
matter what the configuration says. The "nvmem" attribute does
respect the setting of the root_only configuration bit, so do the
same for "eeprom".

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: b6c217ab ("nvmem: Add backwards compatibility support for older EEPROM drivers.")
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20190728184255.563332e6@endymion


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d21a95e0

drivers/nvmem/nvmem-sysfs.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -224,10 +224,17 @@ int nvmem_sysfs_setup_compat(struct nvmem_device *nvmem,
		if (!config->base_dev)
		return -EINVAL;

		if (nvmem->read_only)
		if (nvmem->read_only) {
		if (config->root_only)
		nvmem->eeprom = bin_attr_ro_root_nvmem;
		else
		nvmem->eeprom = bin_attr_ro_nvmem;
		} else {
		if (config->root_only)
		nvmem->eeprom = bin_attr_rw_root_nvmem;
		else
		nvmem->eeprom = bin_attr_rw_nvmem;
		}
		nvmem->eeprom.attr.name = "eeprom";
		nvmem->eeprom.size = nvmem->size;
		#ifdef CONFIG_DEBUG_LOCK_ALLOC