Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6ee6ae4 authored by Shuah Khan (Samsung OSG)'s avatar Shuah Khan (Samsung OSG)
Browse files

selftests: mqueue: return Kselftest Skip code for skipped tests 



When mqueue test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent e1890c50

tools/testing/selftests/mqueue/mq_open_tests.c

+4 −4
Original line number Diff line number Diff line
@@ -33,6 +33,8 @@ 
#include <mqueue.h>

#include <error.h>



#include "../kselftest.h"



static char *usage =

"Usage:\n"

"  %s path\n"
@@ -262,12 +264,10 @@ int main(int argc, char *argv[]) 
		}

	}



	if (getuid() != 0) {

		fprintf(stderr, "Not running as root, but almost all tests "

	if (getuid() != 0)

		ksft_exit_skip("Not running as root, but almost all tests "

			"require root in order to modify\nsystem settings.  "

			"Exiting.\n");

		exit(1);

	}



	/* Find out what files there are for us to make tweaks in */

	def_msgs = fopen(DEF_MSGS, "r+");

tools/testing/selftests/mqueue/mq_perf_tests.c

+4 −4
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ 
#include <popt.h>

#include <error.h>



#include "../kselftest.h"



static char *usage =

"Usage:\n"

"  %s [-c #[,#..] -f] path\n"
@@ -626,12 +628,10 @@ int main(int argc, char *argv[]) 
		cpus_to_pin[0] = cpus_online - 1;

	}



	if (getuid() != 0) {

		fprintf(stderr, "Not running as root, but almost all tests "

	if (getuid() != 0)

		ksft_exit_skip("Not running as root, but almost all tests "

			"require root in order to modify\nsystem settings.  "

			"Exiting.\n");

		exit(1);

	}



	max_msgs = fopen(MAX_MSGS, "r+");

	max_msgsize = fopen(MAX_MSGSIZE, "r+");