Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6b6c483 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Paolo Bonzini
Browse files

KVM: x86: hyperv: fix 'tlb_lush' typo 



Regardless of whether your TLB is lush or not it still needs flushing.

Reported-by: default avatarRoman Kagan <rkagan@virtuozzo.com>
Reviewed-by: default avatarRoman Kagan <rkagan@virtuozzo.com>
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 2768c0cc

arch/x86/include/asm/kvm_host.h

+1 −1
Original line number Diff line number Diff line
@@ -499,7 +499,7 @@ struct kvm_vcpu_hv { 
	struct kvm_hyperv_exit exit;

	struct kvm_vcpu_hv_stimer stimer[HV_SYNIC_STIMER_COUNT];

	DECLARE_BITMAP(stimer_pending_bitmap, HV_SYNIC_STIMER_COUNT);

	cpumask_t tlb_lush;

	cpumask_t tlb_flush;

};



struct kvm_vcpu_arch {

arch/x86/kvm/hyperv.c

+3 −3
Original line number Diff line number Diff line
@@ -1354,12 +1354,12 @@ static u64 kvm_hv_flush_tlb(struct kvm_vcpu *current_vcpu, u64 ingpa, 
	 * vcpu->arch.cr3 may not be up-to-date for running vCPUs so we can't

	 * analyze it here, flush TLB regardless of the specified address space.

	 */

	cpumask_clear(&hv_vcpu->tlb_lush);

	cpumask_clear(&hv_vcpu->tlb_flush);



	if (all_cpus) {

		kvm_make_vcpus_request_mask(kvm,

				    KVM_REQ_TLB_FLUSH | KVM_REQUEST_NO_WAKEUP,

				    NULL, &hv_vcpu->tlb_lush);

				    NULL, &hv_vcpu->tlb_flush);

		goto ret_success;

	}
@@ -1397,7 +1397,7 @@ static u64 kvm_hv_flush_tlb(struct kvm_vcpu *current_vcpu, u64 ingpa, 
flush_request:

	kvm_make_vcpus_request_mask(kvm,

				    KVM_REQ_TLB_FLUSH | KVM_REQUEST_NO_WAKEUP,

				    vcpu_bitmap, &hv_vcpu->tlb_lush);

				    vcpu_bitmap, &hv_vcpu->tlb_flush);



ret_success:

	/* We always do full TLB flush, set rep_done = rep_cnt. */