Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6803efa authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Always check the qla2x00_wait_for_hba_online() return value 



This patch fixes several Coverity complaints about not always checking
the qla2x00_wait_for_hba_online() return value.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c4707fcc

drivers/scsi/qla2xxx/qla_attr.c

+2 −1
Original line number Diff line number Diff line
@@ -724,7 +724,8 @@ qla2x00_sysfs_write_reset(struct file *filp, struct kobject *kobj, 
			break;

		} else {

			/* Make sure FC side is not in reset */

			qla2x00_wait_for_hba_online(vha);

			WARN_ON_ONCE(qla2x00_wait_for_hba_online(vha) !=

				     QLA_SUCCESS);



			/* Issue MPI reset */

			scsi_block_requests(vha->host);

drivers/scsi/qla2xxx/qla_target.c

+5 −2
Original line number Diff line number Diff line
@@ -6673,7 +6673,8 @@ qlt_enable_vha(struct scsi_qla_host *vha) 
	} else {

		set_bit(ISP_ABORT_NEEDED, &base_vha->dpc_flags);

		qla2xxx_wake_dpc(base_vha);

		qla2x00_wait_for_hba_online(base_vha);

		WARN_ON_ONCE(qla2x00_wait_for_hba_online(base_vha) !=

			     QLA_SUCCESS);

	}

	mutex_unlock(&ha->optrom_mutex);

}
@@ -6704,7 +6705,9 @@ static void qlt_disable_vha(struct scsi_qla_host *vha) 


	set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags);

	qla2xxx_wake_dpc(vha);

	qla2x00_wait_for_hba_online(vha);

	if (qla2x00_wait_for_hba_online(vha) != QLA_SUCCESS)

		ql_dbg(ql_dbg_tgt, vha, 0xe081,

		       "qla2x00_wait_for_hba_online() failed\n");

}



/*