Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e65449aa authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Simplify qlt_send_term_imm_notif() 



All qlt_send_term_imm_notif() callers pass '1' as second argument to this
function. Hence remove the (broken) code that depends on that second
argument having another value. Add a pr_debug() statement that prints rc to
avoid that the compiler would complain that rc has been set but is not
used.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Acked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d8f945bf

drivers/scsi/qla2xxx/qla_target.c

+2 −24
Original line number Diff line number Diff line
@@ -3651,33 +3651,11 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha, 
static void qlt_send_term_imm_notif(struct scsi_qla_host *vha,

	struct imm_ntfy_from_isp *imm, int ha_locked)

{

	unsigned long flags = 0;

	int rc;



	if (ha_locked) {

	WARN_ON_ONCE(!ha_locked);

	rc = __qlt_send_term_imm_notif(vha, imm);



#if 0	/* Todo  */

		if (rc == -ENOMEM)

			qlt_alloc_qfull_cmd(vha, imm, 0, 0);

#else

		if (rc) {

		}

#endif

		goto done;

	}



	spin_lock_irqsave(&vha->hw->hardware_lock, flags);

	rc = __qlt_send_term_imm_notif(vha, imm);



#if 0	/* Todo */

	if (rc == -ENOMEM)

		qlt_alloc_qfull_cmd(vha, imm, 0, 0);

#endif



done:

	if (!ha_locked)

		spin_unlock_irqrestore(&vha->hw->hardware_lock, flags);

	pr_debug("rc = %d\n", rc);

}



/*