Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6364854 authored by Marcus Folkesson's avatar Marcus Folkesson Committed by Greg Kroah-Hartman
Browse files

HID: hid-sensor-custom: set fixed size for custom attributes 



[ Upstream commit 9d013910df22de91333a0acc81d1dbb115bd76f6 ]

This is no bugfix (so no Fixes: tag is necessary) as it is
taken care of in hid_sensor_custom_add_attributes().

The motivation for this patch is that:
hid_sensor_custom_field.attr_name and
hid_sensor_custom_field.attrs
has the size of HID_CUSTOM_TOTAL_ATTRS and used in same context.

We compare against HID_CUSTOM_TOTAL_ATTRS when
looping through hid_custom_attrs.

We will silent the smatch error:
hid_sensor_custom_add_attributes() error: buffer overflow
'hid_custom_attrs' 8 <= 10

Signed-off-by: default avatarMarcus Folkesson <marcus.folkesson@gmail.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 75a5bf8e

drivers/hid/hid-sensor-custom.c

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ struct hid_sensor_sample { 
	u32 raw_len;

} __packed;



static struct attribute hid_custom_attrs[] = {

static struct attribute hid_custom_attrs[HID_CUSTOM_TOTAL_ATTRS] = {

	{.name = "name", .mode = S_IRUGO},

	{.name = "units", .mode = S_IRUGO},

	{.name = "unit-expo", .mode = S_IRUGO},