Commit e5ea79bb authored Oct 31, 2020 by YueHaibing Committed by Greg Kroah-Hartman Nov 10, 2020

sfp: Fix error handing in sfp_probe()



[ Upstream commit 9621618130bf7e83635367c13b9a6ee53935bb37 ]

gpiod_to_irq() never return 0, but returns negative in
case of error, check it and set gpio_irq to 0.

Fixes: 73970055 ("sfp: add SFP module support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9b5458ef

drivers/net/phy/sfp.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1970,7 +1970,8 @@ static int sfp_probe(struct platform_device *pdev)
		continue;

		sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]);
		if (!sfp->gpio_irq[i]) {
		if (sfp->gpio_irq[i] < 0) {
		sfp->gpio_irq[i] = 0;
		poll = true;
		continue;
		}