Commit e5ea3dca authored Sep 04, 2021 by Barnabás Pőcze Committed by Greg Kroah-Hartman Nov 17, 2021

platform/x86: wmi: do not fail if disabling fails



[ Upstream commit 1975718c488a39128f1f515b23ae61a5a214cc3d ]

Previously, `__query_block()` would fail if the
second WCxx method call failed. However, the
WQxx method might have succeeded, and potentially
allocated memory for the result. Instead of
throwing away the result and potentially
leaking memory, ignore the result of
the second WCxx call.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Link: https://lore.kernel.org/r/20210904175450.156801-25-pobrn@protonmail.com


Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b57df4d6

drivers/platform/x86/wmi.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -353,7 +353,14 @@ static acpi_status __query_block(struct wmi_block *wblock, u8 instance,
		* the WQxx method failed - we should disable collection anyway.
		*/
		if ((block->flags & ACPI_WMI_EXPENSIVE) && ACPI_SUCCESS(wc_status)) {
		status = acpi_execute_simple_method(handle, wc_method, 0);
		/*
		* Ignore whether this WCxx call succeeds or not since
		* the previously executed WQxx method call might have
		* succeeded, and returning the failing status code
		* of this call would throw away the result of the WQxx
		* call, potentially leaking memory.
		*/
		acpi_execute_simple_method(handle, wc_method, 0);
		}

		return status;