Commit e5c97a43 authored Nov 23, 2022 by YueHaibing Committed by Greg Kroah-Hartman Jan 18, 2023

staging: rtl8192e: Fix potential use-after-free in rtllib_rx_Monitor()



[ Upstream commit d30f4436f364b4ad915ca2c09be07cd0f93ceb44 ]

The skb is delivered to netif_rx() in rtllib_monitor_rx(), which may free it,
after calling this, dereferencing skb may trigger use-after-free.
Found by Smatch.

Fixes: 94a79942 ("From: wlanfae <wlanfae@realtek.com> [PATCH 1/8] rtl8192e: Import new version of driver from realtek")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20221123081253.22296-1-yuehaibing@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 288ada16

drivers/staging/rtl8192e/rtllib_rx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1490,9 +1490,9 @@ static int rtllib_rx_Monitor(struct rtllib_device ieee, struct sk_buff skb,
		hdrlen += 4;
		}

		rtllib_monitor_rx(ieee, skb, rx_stats, hdrlen);
		ieee->stats.rx_packets++;
		ieee->stats.rx_bytes += skb->len;
		rtllib_monitor_rx(ieee, skb, rx_stats, hdrlen);

		return 1;
		}