Commit e549a17f authored Mar 10, 2010 by Michael Brunner Committed by Greg Kroah-Hartman Mar 19, 2010

USB: cp210x: Remove double usb_control_msg from cp210x_set_config



This patch removes a double usb_control_msg that sets the cp210x
configuration registers a second time when calling cp210x_set_config.
For data sizes >2 the second write gets corrupted.
The patch has been created against 2.6.34-rc1, but all cp210x driver
revisions are affected.

Signed-off-by: Michael Brunner <mibru@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 7f56cfd2

drivers/usb/serial/cp210x.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -313,11 +313,6 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
		return -EPROTO;
		}

		/* Single data value */
		result = usb_control_msg(serial->dev,
		usb_sndctrlpipe(serial->dev, 0),
		request, REQTYPE_HOST_TO_DEVICE, data[0],
		0, NULL, 0, 300);
		return 0;
		}