Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4cf6f88 authored by Namhyung Kim's avatar Namhyung Kim Committed by Jiri Olsa
Browse files

perf ui/gtk: Fix callchain display 



With current output field change, GTK browser cannot display callchain
information correctly since it couldn't determine where the symbol
column is.  This is a problem - just for now I changed to use the last
column since it'll work for most cases.

Also it has a same problem of the percentage as stdio code.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Arun Sharma <asharma@fb.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/1401335910-16832-25-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
parent 56772ad4

tools/perf/ui/gtk/hists.c

+9 −1
Original line number Diff line number Diff line
@@ -198,6 +198,13 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists, 
		if (perf_hpp__should_skip(fmt))

			continue;



		/*

		 * XXX no way to determine where symcol column is..

		 *     Just use last column for now.

		 */

		if (perf_hpp__is_sort_entry(fmt))

			sym_col = col_idx;



		fmt->header(fmt, &hpp, hists_to_evsel(hists));



		gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view),
@@ -253,7 +260,8 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists, 


		if (symbol_conf.use_callchain && sort__has_sym) {

			if (callchain_param.mode == CHAIN_GRAPH_REL)

				total = h->stat.period;

				total = symbol_conf.cumulate_callchain ?

					h->stat_acc->period : h->stat.period;



			perf_gtk__add_callchain(&h->sorted_chain, store, &iter,

						sym_col, total);