Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4c5c820 authored by Antonino A. Daplas's avatar Antonino A. Daplas Committed by Linus Torvalds
Browse files

[PATCH] fbdev: Replace memcpy with for-loop when preparing bitmap 



Do not use memcpy in fb_pad_aligned_buffer.  It is suboptimal because only
a few bytes are moved at a time.  Replace with a for-loop.

Signed-off-by: default avatarAntonino Daplas <adaplas@pol.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent e1afc3f5

drivers/video/fbmem.c

+4 −2
Original line number Diff line number Diff line
@@ -80,10 +80,12 @@ EXPORT_SYMBOL(fb_get_color_depth); 
 */

void fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32 height)

{

	int i;

	int i, j;



	for (i = height; i--; ) {

		memcpy(dst, src, s_pitch);

		/* s_pitch is a few bytes at the most, memcpy is suboptimal */

		for (j = 0; j < s_pitch; j++)

			dst[j] = src[j];

		src += s_pitch;

		dst += d_pitch;

	}