Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4bb2240 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Eduardo Valentin
Browse files

thermal: imx: Use better parameter names than "val" 



The values passed to imx_init_calib() and imx_init_temp_grade() are
read from specific OCOTP values. Use their names (in lower case) as
parameter name instead of "val" to make the code easier to understand.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent d790405d

drivers/thermal/imx_thermal.c

+5 −5
Original line number Diff line number Diff line
@@ -347,13 +347,13 @@ static struct thermal_zone_device_ops imx_tz_ops = { 
	.set_trip_temp = imx_set_trip_temp,

};



static int imx_init_calib(struct platform_device *pdev, u32 val)

static int imx_init_calib(struct platform_device *pdev, u32 ocotp_ana1)

{

	struct imx_thermal_data *data = platform_get_drvdata(pdev);

	int t1, n1;

	u64 temp64;



	if (val == 0 || val == ~0) {

	if (ocotp_ana1 == 0 || ocotp_ana1 == ~0) {

		dev_err(&pdev->dev, "invalid sensor calibration data\n");

		return -EINVAL;

	}
@@ -364,7 +364,7 @@ static int imx_init_calib(struct platform_device *pdev, u32 val) 
	 * Use universal formula now and only need sensor value @ 25C

	 * slope = 0.4297157 - (0.0015976 * 25C fuse)

	 */

	n1 = val >> 20;

	n1 = ocotp_ana1 >> 20;

	t1 = 25; /* t1 always 25C */



	/*
@@ -392,12 +392,12 @@ static int imx_init_calib(struct platform_device *pdev, u32 val) 
	return 0;

}



static void imx_init_temp_grade(struct platform_device *pdev, u32 val)

static void imx_init_temp_grade(struct platform_device *pdev, u32 ocotp_mem0)

{

	struct imx_thermal_data *data = platform_get_drvdata(pdev);



	/* The maximum die temp is specified by the Temperature Grade */

	switch ((val >> 6) & 0x3) {

	switch ((ocotp_mem0 >> 6) & 0x3) {

	case 0: /* Commercial (0 to 95C) */

		data->temp_grade = "Commercial";

		data->temp_max = 95000;