Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4b474fa authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Greg Kroah-Hartman
Browse files

can: sja1000_isa: sja1000_isa_probe(): add missing free_sja1000dev() 



[ Upstream commit 92dfd9310a71d28cefe6a2d5174d43fab240e631 ]

Add the missing free_sja1000dev() before return from
sja1000_isa_probe() in the register_sja1000dev() error handling case.

In addition, remove blanks before goto labels.

Fixes: 2a6ba39a ("can: sja1000: legacy SJA1000 ISA bus driver")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/all/1668168521-5540-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0a2d73a7

drivers/net/can/sja1000/sja1000_isa.c

+6 −4
Original line number Diff line number Diff line
@@ -202,13 +202,15 @@ static int sja1000_isa_probe(struct platform_device *pdev) 
	if (err) {

		dev_err(&pdev->dev, "registering %s failed (err=%d)\n",

			DRV_NAME, err);

		goto exit_unmap;

		goto exit_free;

	}



	dev_info(&pdev->dev, "%s device registered (reg_base=0x%p, irq=%d)\n",

		 DRV_NAME, priv->reg_base, dev->irq);

	return 0;



exit_free:

	free_sja1000dev(dev);

exit_unmap:

	if (mem[idx])

		iounmap(base);