Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4a97625 authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Christoph Hellwig
Browse files

nvmet: add error-log definitions 



This patch adds necessary fields in the target data structures to
support error log page. For a target controller, we add a new error log
field to maintain the error log, at any given point we maintain error
entries equal to NVMET_ERROR_LOG_SLOTS for each controller. In the
following patch, we also update the error log page entry in the I/O
completion path so we introduce a spinlock for synchronization of the
log.

For nvmet_req, we add a new field error_loc to hold the location of
the error in the command when the actual error occurs for each request
and a starting LBA if applicable.

Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent b34de7ce

drivers/nvme/target/core.c

+5 −0
Original line number Diff line number Diff line
@@ -769,6 +769,8 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq, 
	req->rsp->status = 0;

	req->rsp->sq_head = 0;

	req->ns = NULL;

	req->error_loc = -1;

	req->error_slba = 0;



	/* no support for fused commands yet */

	if (unlikely(flags & (NVME_CMD_FUSE_FIRST | NVME_CMD_FUSE_SECOND))) {
@@ -1174,6 +1176,9 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn, 
	/* keep-alive timeout in seconds */

	ctrl->kato = DIV_ROUND_UP(kato, 1000);



	ctrl->err_counter = 0;

	spin_lock_init(&ctrl->error_lock);



	nvmet_start_keep_alive_timer(ctrl);



	mutex_lock(&subsys->lock);

drivers/nvme/target/nvmet.h

+6 −0
Original line number Diff line number Diff line
@@ -202,6 +202,10 @@ struct nvmet_ctrl { 


	struct device		*p2p_client;

	struct radix_tree_root	p2p_ns_map;



	spinlock_t		error_lock;

	u64			err_counter;

	struct nvme_error_slot	slots[NVMET_ERROR_LOG_SLOTS];

};



struct nvmet_subsys {
@@ -317,6 +321,8 @@ struct nvmet_req { 


	struct pci_dev		*p2p_dev;

	struct device		*p2p_client;

	u16			error_loc;

	u64			error_slba;

};



extern struct workqueue_struct *buffered_io_wq;