Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e469ebb2 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Greg Kroah-Hartman
Browse files

iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip 



commit 363c7dc72f79edd55bf1c4380e0fbf7f1bbc2c86 upstream.

The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks.
This means these callbacks can sleep and the `can_sleep` flag should be
set.

Having the flag set will make sure that warnings are generated when calling
any of the callbacks from a potentially non-sleeping context.

Fixes: c97dce79 ("iio: adc: ti-ads7950: add GPIO support")
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Acked-by: default avatarDavid Lechner <david@lechnology.com>
Link: https://lore.kernel.org/r/20230312210933.2275376-1-lars@metafoo.de


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent abc5b4f8

drivers/iio/adc/ti-ads7950.c

+1 −0
Original line number Diff line number Diff line
@@ -635,6 +635,7 @@ static int ti_ads7950_probe(struct spi_device *spi) 
	st->chip.label = dev_name(&st->spi->dev);

	st->chip.parent = &st->spi->dev;

	st->chip.owner = THIS_MODULE;

	st->chip.can_sleep = true;

	st->chip.base = -1;

	st->chip.ngpio = TI_ADS7950_NUM_GPIOS;

	st->chip.get_direction = ti_ads7950_get_direction;