Commit e464aafd authored Feb 18, 2022 by Souptick Joarder (HPE) Committed by Greg Kroah-Hartman Apr 15, 2022

irqchip/nvic: Release nvic_base upon failure



[ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ]

smatch warning was reported as below ->

smatch warnings:
drivers/irqchip/irq-nvic.c:131 nvic_of_init()
warn: 'nvic_base' not released on lines: 97.

Release nvic_base upon failure.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c159eb63

drivers/irqchip/irq-nvic.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -105,6 +105,7 @@ static int __init nvic_of_init(struct device_node *node,

		if (!nvic_irq_domain) {
		pr_warn("Failed to allocate irq domain\n");
		iounmap(nvic_base);
		return -ENOMEM;
		}

		@@ -114,6 +115,7 @@ static int __init nvic_of_init(struct device_node *node,
		if (ret) {
		pr_warn("Failed to allocate irq chips\n");
		irq_domain_remove(nvic_irq_domain);
		iounmap(nvic_base);
		return ret;
		}