Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4648309 authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

fuse: truncate pending writes on O_TRUNC 



Make sure cached writes are not reordered around open(..., O_TRUNC), with
the obvious wrong results.

Fixes: 4d99ff8f ("fuse: Turn writeback cache on")
Cc: <stable@vger.kernel.org> # v3.15+
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent b24e7598

fs/fuse/file.c

+7 −3
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ int fuse_open_common(struct inode *inode, struct file *file, bool isdir) 
{

	struct fuse_conn *fc = get_fuse_conn(inode);

	int err;

	bool lock_inode = (file->f_flags & O_TRUNC) &&

	bool is_wb_truncate = (file->f_flags & O_TRUNC) &&

			  fc->atomic_o_trunc &&

			  fc->writeback_cache;
@@ -225,16 +225,20 @@ int fuse_open_common(struct inode *inode, struct file *file, bool isdir) 
	if (err)

		return err;



	if (lock_inode)

	if (is_wb_truncate) {

		inode_lock(inode);

		fuse_set_nowrite(inode);

	}



	err = fuse_do_open(fc, get_node_id(inode), file, isdir);



	if (!err)

		fuse_finish_open(inode, file);



	if (lock_inode)

	if (is_wb_truncate) {

		fuse_release_nowrite(inode);

		inode_unlock(inode);

	}



	return err;

}