Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e44d4063 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Greg Kroah-Hartman
Browse files

net: qede: use return from qede_parse_flow_attr() for flower 



[ Upstream commit fcee2065a178f78be6fd516302830378b17dba3d ]

In qede_add_tc_flower_fltr(), when calling
qede_parse_flow_attr() then the return code
was only used for a non-zero check, and then
-EINVAL was returned.

qede_parse_flow_attr() can currently fail with:
* -EINVAL
* -EOPNOTSUPP
* -EPROTONOSUPPORT

This patch changes the code to use the actual
return code, not just return -EINVAL.

The blaimed commit introduced these functions.

Only compile tested.

Fixes: 2ce9c93e ("qede: Ingress tc flower offload (drop action) support.")
Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e4bb83fb

drivers/net/ethernet/qlogic/qede/qede_filter.c

+2 −3
Original line number Diff line number Diff line
@@ -1960,10 +1960,9 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto, 
	}



	/* parse flower attribute and prepare filter */

	if (qede_parse_flow_attr(edev, proto, f->rule, &t)) {

		rc = -EINVAL;

	rc = qede_parse_flow_attr(edev, proto, f->rule, &t);

	if (rc)

		goto unlock;

	}



	/* Validate profile mode and number of filters */

	if ((edev->arfs->filter_count && edev->arfs->mode != t.mode) ||