Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3c19503 authored by Gal Pressman's avatar Gal Pressman Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix ethtool pause support and advertise reporting 



Pause bit should set when RX pause is on, not TX pause.
Also, setting Asym_Pause is incorrect, and should be turned off.

Fixes: 665bc539 ("net/mlx5e: Use new ethtool get/set link ksettings API")
Signed-off-by: default avatarGal Pressman <galp@mellanox.com>
Cc: kernel-team@fb.com
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent b383b544

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

+1 −2
Original line number Diff line number Diff line
@@ -794,7 +794,6 @@ static void get_supported(u32 eth_proto_cap, 
	ptys2ethtool_supported_port(link_ksettings, eth_proto_cap);

	ptys2ethtool_supported_link(supported, eth_proto_cap);

	ethtool_link_ksettings_add_link_mode(link_ksettings, supported, Pause);

	ethtool_link_ksettings_add_link_mode(link_ksettings, supported, Asym_Pause);

}



static void get_advertising(u32 eth_proto_cap, u8 tx_pause,
@@ -804,7 +803,7 @@ static void get_advertising(u32 eth_proto_cap, u8 tx_pause, 
	unsigned long *advertising = link_ksettings->link_modes.advertising;



	ptys2ethtool_adver_link(advertising, eth_proto_cap);

	if (tx_pause)

	if (rx_pause)

		ethtool_link_ksettings_add_link_mode(link_ksettings, advertising, Pause);

	if (tx_pause ^ rx_pause)

		ethtool_link_ksettings_add_link_mode(link_ksettings, advertising, Asym_Pause);