Commit e35e26b2 authored Dec 07, 2018 by Carlo Caione Committed by Kevin Hilman Jan 10, 2019

arm: dts: meson: Fix IRQ trigger type for macirq



A long running stress test on a custom board shipping an AXG SoCs and a
Realtek RTL8211F PHY revealed that after a few hours the connection
speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
the 'macirq' (eth0) IRQ would stop being triggered at all and as
consequence the GMAC IRQs never ACKed.

After a painful investigation the problem seemed to be due to a wrong
defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
EDGE_RISING.

The change in the macirq IRQ type also solved another long standing
issue affecting this SoC/PHY where EEE was causing the network
connection to die after stressing it with iperf3 (even though much
sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
well.

Fixes: 9c15795a ("ARM: dts: meson8b-odroidc1: ethernet support")
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>

parent 19a220dd

arch/arm/boot/dts/meson.dtsi

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@
		compatible = "amlogic,meson6-dwmac", "snps,dwmac";
		reg = <0xc9410000 0x10000
		0xc1108108 0x4>;
		interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>;
		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
		interrupt-names = "macirq";
		status = "disabled";
		};

arch/arm/boot/dts/meson8b-odroidc1.dts

+0 −1

Original line number	Diff line number	Diff line
		@@ -221,7 +221,6 @@
		/* Realtek RTL8211F (0x001cc916) */
		eth_phy: ethernet-phy@0 {
		reg = <0>;
		eee-broken-1000t;
		interrupt-parent = <&gpio_intc>;
		/* GPIOH_3 */
		interrupts = <17 IRQ_TYPE_LEVEL_LOW>;