Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3373e6b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

firmware: stratix10-svc: Fix a potential resource leak in svc_create_memory_pool() 

commit 1995f15590ca222f91193ed11461862b450abfd6 upstream.

svc_create_memory_pool() is only called from stratix10_svc_drv_probe().
Most of resources in the probe are managed, but not this memremap() call.

There is also no memunmap() call in the file.

So switch to devm_memremap() to avoid a resource leak.

Cc: stable@vger.kernel.org
Fixes: 7ca5ce89 ("firmware: add Intel Stratix10 service layer driver")
Link: https://lore.kernel.org/all/783e9dfbba34e28505c9efa8bba41f97fd0fa1dc.1686109400.git.christophe.jaillet@wanadoo.fr/


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDinh Nguyen <dinguyen@kernel.org>
Message-ID: <20230613211521.16366-1-dinguyen@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 826c7bfe

drivers/firmware/stratix10-svc.c

+1 −1
Original line number Diff line number Diff line
@@ -615,7 +615,7 @@ svc_create_memory_pool(struct platform_device *pdev, 
	end = rounddown(sh_memory->addr + sh_memory->size, PAGE_SIZE);

	paddr = begin;

	size = end - begin;

	va = memremap(paddr, size, MEMREMAP_WC);

	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);

	if (!va) {

		dev_err(dev, "fail to remap shared memory\n");

		return ERR_PTR(-EINVAL);