Commit e2eb179c authored Jan 11, 2017 by Colin Ian King Committed by Jonathan Cameron Jan 14, 2017

iio: magnetometer: ak8974: remove redundant zero timeout check



At the end of the delay loop timeout will always be zero
and hence the check for !timeout will always be true. Remove
the redundant check and the redundant return 0 at the end of
the function.

Fixes CoverityScan CID#1357168 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent a9c99c76

drivers/iio/magnetometer/ak8974.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -278,13 +278,9 @@ static int ak8974_await_drdy(struct ak8974 *ak8974)
		if (val & AK8974_STATUS_DRDY)
		return 0;
		} while (--timeout);
		if (!timeout) {
		dev_err(&ak8974->i2c->dev,
		"timeout waiting for DRDY\n");
		return -ETIMEDOUT;
		}

		return 0;
		dev_err(&ak8974->i2c->dev, "timeout waiting for DRDY\n");
		return -ETIMEDOUT;
		}

		static int ak8974_getresult(struct ak8974 ak8974, __le16 result)