Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2c114c0 authored by Nicolas Ferre's avatar Nicolas Ferre Committed by Vinod Koul
Browse files

dmaengine: at_xdmac: remove BUG_ON macro in tasklet 



Even if this case shouldn't happen when controller is properly programmed,
it's still better to avoid dumping a kernel Oops for this.
As the sequence may happen only for debugging purposes, log the error and
just finish the tasklet call.

Signed-off-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: default avatarLudovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 23b84639

drivers/dma/at_xdmac.c

+5 −1
Original line number Diff line number Diff line
@@ -1606,7 +1606,11 @@ static void at_xdmac_tasklet(unsigned long data) 
					struct at_xdmac_desc,

					xfer_node);

		dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);

		BUG_ON(!desc->active_xfer);

		if (!desc->active_xfer) {

			dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting");

			spin_unlock_bh(&atchan->lock);

			return;

		}



		txd = &desc->tx_dma_desc;