Commit e2c063c8 authored Jul 13, 2019 by Fuqian Huang Committed by Dmitry Torokhov Jul 13, 2019

Input: auo-pixcir-ts - switch to using devm_add_action_or_reset()



devm_add_action_or_reset() is introduced as a helper function which
internally calls devm_add_action(). If devm_add_action() fails
then it will execute the action mentioned and return the error code.
This reduce source code size (avoid writing the action twice)
and reduce the likelyhood of bugs.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 2a017fd8

drivers/input/touchscreen/auo-pixcir-ts.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -612,9 +612,8 @@ static int auo_pixcir_probe(struct i2c_client *client,
		return error;
		}

		error = devm_add_action(&client->dev, auo_pixcir_reset, ts);
		error = devm_add_action_or_reset(&client->dev, auo_pixcir_reset, ts);
		if (error) {
		auo_pixcir_reset(ts);
		dev_err(&client->dev, "failed to register reset action, %d\n",
		error);
		return error;