Commit e2932632 authored Nov 18, 2022 by Xiongfeng Wang Committed by Greg Kroah-Hartman Jan 18, 2023

perf/x86/intel/uncore: Fix reference count leak in hswep_has_limit_sbox()



[ Upstream commit 1ff9dd6e7071a561f803135c1d684b13c7a7d01d ]

pci_get_device() will increase the reference count for the returned
'dev'. We need to call pci_dev_put() to decrease the reference count.
Since 'dev' is only used in pci_read_config_dword(), let's add
pci_dev_put() right after it.

Fixes: 9d480158ee86 ("perf/x86/intel/uncore: Remove uncore extra PCI dev HSWEP_PCI_PCU_3")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-3-wangxiongfeng2@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 81b024df

arch/x86/events/intel/uncore_snbep.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2762,6 +2762,7 @@ static bool hswep_has_limit_sbox(unsigned int device)
		return false;

		pci_read_config_dword(dev, HSWEP_PCU_CAPID4_OFFET, &capid4);
		pci_dev_put(dev);
		if (!hswep_get_chop(capid4))
		return true;