Commit e29289d0 authored Oct 28, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Nov 25, 2022

HID: hyperv: fix possible memory leak in mousevsc_probe()



[ Upstream commit b5bcb94b0954a026bbd671741fdb00e7141f9c91 ]

If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().

Fixes: 74c4fb05 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d975bec1

drivers/hid/hid-hyperv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -492,7 +492,7 @@ static int mousevsc_probe(struct hv_device *device,

		ret = hid_add_device(hid_dev);
		if (ret)
		goto probe_err1;
		goto probe_err2;


		ret = hid_parse(hid_dev);