Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e28f4d59 authored by Jingoo Han's avatar Jingoo Han Committed by David S. Miller
Browse files

net: ns83820: remove unnecessary pci_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent add0cdb4

drivers/net/ethernet/natsemi/ns83820.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -2235,7 +2235,6 @@ static int ns83820_init_one(struct pci_dev *pci_dev, 
	pci_disable_device(pci_dev);

	pci_disable_device(pci_dev);

out_free:

out_free:

	free_netdev(ndev);

	free_netdev(ndev);

	pci_set_drvdata(pci_dev, NULL);

out:

out:

	return err;

	return err;

}

}
@@ -2259,7 +2258,6 @@ static void ns83820_remove_one(struct pci_dev *pci_dev) 
			dev->rx_info.descs, dev->rx_info.phy_descs);

			dev->rx_info.descs, dev->rx_info.phy_descs);

	pci_disable_device(dev->pci_dev);

	pci_disable_device(dev->pci_dev);

	free_netdev(ndev);

	free_netdev(ndev);

	pci_set_drvdata(pci_dev, NULL);

}

}





static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {

static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {