Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e28cd4d0 authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm: Automatically register/unregister all connectors 



As the drm_connector is now safe for multiple calls to
register/unregister, automatically perform a registration on all known
connectors drm drv_register (and unregister from drm_drv_unregister).
Drivers can still call drm_connector_register() and
drm_connector_unregister() individually, or defer as required.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-2-git-send-email-chris@chris-wilson.co.uk
parent acd8f414

drivers/gpu/drm/drm_crtc.c

+3 −3
Original line number Diff line number Diff line
@@ -1047,9 +1047,9 @@ EXPORT_SYMBOL(drm_connector_unregister); 
 * @dev: drm device

 *

 * This function registers all connectors in sysfs and other places so that

 * userspace can start to access them. Drivers can call it after calling

 * drm_dev_register() to complete the device registration, if they don't call

 * drm_connector_register() on each connector individually.

 * userspace can start to access them. drm_connector_register_all() is called

 * automatically from drm_dev_register() to complete the device registration,

 * if they don't call drm_connector_register() on each connector individually.

 *

 * When a device is unplugged and should be removed from userspace access,

 * call drm_connector_unregister_all(), which is the inverse of this

drivers/gpu/drm/drm_drv.c

+5 −5
Original line number Diff line number Diff line
@@ -650,11 +650,7 @@ EXPORT_SYMBOL(drm_dev_unref); 
 *

 * Register the DRM device @dev with the system, advertise device to user-space

 * and start normal device operation. @dev must be allocated via drm_dev_alloc()

 * previously. Right after drm_dev_register() the driver should call

 * drm_connector_register_all() to register all connectors in sysfs. This is

 * a separate call for backward compatibility with drivers still using

 * the deprecated ->load() callback, where connectors are registered from within

 * the ->load() callback.

 * previously.

 *

 * Never call this twice on any device!

 *
@@ -691,6 +687,8 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags) 
			goto err_minors;

	}



	drm_connector_register_all(dev);



	ret = 0;

	goto out_unlock;
@@ -721,6 +719,8 @@ void drm_dev_unregister(struct drm_device *dev) 


	drm_lastclose(dev);



	drm_connector_unregister_all(dev);



	if (dev->driver->unload)

		dev->driver->unload(dev);