Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e27ffe7e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Darren Hart
Browse files

surfacepro3_button: Add a warning when switching to tablet mode 



Microsoft Surface Book has a tablet mode button. Print another message
once on this event instead of repeating "Unknown event...".

Unfortunately, proper support involves the _DSM method, which is not a
discoverable interface. Just print a warning for now.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent ddd9357f

drivers/platform/x86/surfacepro3_button.c

+7 −2
Original line number Diff line number Diff line
@@ -24,6 +24,8 @@ 
#define SURFACE_BUTTON_OBJ_NAME		"VGBI"

#define SURFACE_BUTTON_DEVICE_NAME	"Surface Pro 3/4 Buttons"



#define SURFACE_BUTTON_NOTIFY_TABLET_MODE	0xc8



#define SURFACE_BUTTON_NOTIFY_PRESS_POWER	0xc6

#define SURFACE_BUTTON_NOTIFY_RELEASE_POWER	0xc7
@@ -105,6 +107,9 @@ static void surface_button_notify(struct acpi_device *device, u32 event) 
	case SURFACE_BUTTON_NOTIFY_RELEASE_VOLUME_DOWN:

		key_code = KEY_VOLUMEDOWN;

		break;

	case SURFACE_BUTTON_NOTIFY_TABLET_MODE:

		dev_warn_once(&device->dev, "Tablet mode is not supported\n");

		break;

	default:

		dev_info_ratelimited(&device->dev,

				     "Unsupported event [0x%x]\n", event);