Commit e25df781 authored Jan 16, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Jan 18, 2019

misc: ibmvsm: Fix potential NULL pointer dereference



There is a potential NULL pointer dereference in case kzalloc()
fails and returns NULL.

Fix this by adding a NULL check on *session*

Also, update the function header with information about the
expected return on failure and remove unnecessary variable rc.

This issue was detected with the help of Coccinelle.

Fixes: 0eca353e ("misc: IBM Virtual Management Channel Driver (VMC)")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7e7ca774

drivers/misc/ibmvmc.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -820,21 +820,24 @@ static int ibmvmc_send_msg(struct crq_server_adapter *adapter,
		*
		* Return:
		* 0 - Success
		* Non-zero - Failure
		*/
		static int ibmvmc_open(struct inode inode, struct file file)
		{
		struct ibmvmc_file_session *session;
		int rc = 0;

		pr_debug("%s: inode = 0x%lx, file = 0x%lx, state = 0x%x\n", __func__,
		(unsigned long)inode, (unsigned long)file,
		ibmvmc.state);

		session = kzalloc(sizeof(*session), GFP_KERNEL);
		if (!session)
		return -ENOMEM;

		session->file = file;
		file->private_data = session;

		return rc;
		return 0;
		}

		/**